Fix advection of vertical momentum and vertical advection of scalars #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
advect_wandadvect_weno_wsethorz_orderandvert_orderlocal variables to the scalar options rather than the momentum options, which is incorrect. This causes failed model runs under certain conditions. The u and v advection subroutines properly set these. Note: This currently persists in WRF codebase.Additionally once this was fixed, vertical advection for scalars couldn't be turned off which horizontal could. The scalar advection code can have horizontal advection off by setting
h_sca_adv_order = 0but there didn't exist logic for vertical advectionv_sca_adv_order = 0. This triggered an error message.