fix(to-json-schema): support integer type for minValue and maxValue actions #1345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
minValueandmaxValueactions in@valibot/to-json-schemaonly supportednumbertype, but JSON Schema supportsminimumandmaximumfor bothnumberandintegertypes. This caused an error when converting schemas that usedv.pipe(v.number(), v.integer(), v.minValue())orv.maxValue().Error message:
Solution
Updated both
min_valueandmax_valueaction handlers inconvertAction.tsto accept both'number'and'integer'types, matching JSON Schema's support for these constraints.Changes
max_valueaction handler to check for bothnumberandintegertypesmin_valueaction handler to check for bothnumberandintegertypesTesting
All tests pass, including 4 new test cases:
convertAction > should convert min value action for integersconvertAction > should convert max value action for integerstoJsonSchema > should convert schema > for integer schema with min valuetoJsonSchema > should convert schema > for integer schema with max valueRun
pnpm test runin thepackages/to-json-schemadirectory to verify.