Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Updated Go to v1.23 and related k8s.io packages #360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ankit152
Copy link

Summary

Updated Golang to v1.23 and related k8s.io packages.

Related issue(s)

Fixes open-cluster-management-io/ocm#868

@openshift-ci openshift-ci bot requested review from deads2k and mdelder March 11, 2025 10:07
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankit152
Once this PR has been reviewed and has the lgtm label, please assign qiujian16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ankit152
Copy link
Author

Hey @haoqing0110 @zhujian7 please take a look into the PR. Thanks! 🙂

@@ -3,8 +3,8 @@
package versioned

import (
"fmt"
"net/http"
fmt "fmt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this auto generated? Is it a new change of golang 1.23?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It was auto generated. 🙂

@zhujian7
Copy link
Member

/ok-to-test

@haoqing0110
Copy link
Member

/hold until we release v0.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade golang to 1.23, k8s.io package to latest.
3 participants