Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command clusterset remove #147

Conversation

ycyaoxdu
Copy link
Member

@ycyaoxdu ycyaoxdu commented Mar 9, 2022

help remove cluster from clusterset

Signed-off-by: ycyaoxdu [email protected]

@openshift-ci openshift-ci bot requested review from itdove and qiujian16 March 9, 2022 07:36
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ycyaoxdu
To complete the pull request process, please assign qiujian16 after the PR has been reviewed.
You can assign the PR to them by writing /assign @qiujian16 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ycyaoxdu
Copy link
Member Author

ycyaoxdu commented Mar 9, 2022

@qiujian16 please help to review, thanks.

@ycyaoxdu ycyaoxdu force-pushed the feat/clusterset-remove branch from 240af62 to 408722a Compare March 9, 2022 09:01
@qiujian16
Copy link
Member

should this be clusteradm delete clusterset ?

@ycyaoxdu
Copy link
Member Author

should this be clusteradm delete clusterset ?

this command clusteradm clusteset remove is meant to remove a cluster from a clusterset. which is an option in a clusterset, just like the clusteradm clusterset add .

from my opinion, clusteradm delete clusterset means to delete a clusterset. we may also need clusteradm delete clusterset to delete a specified clusterset?

@ycyaoxdu
Copy link
Member Author

#151

@ycyaoxdu ycyaoxdu closed this Mar 10, 2022
@ycyaoxdu ycyaoxdu deleted the feat/clusterset-remove branch March 15, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants