Merged
Conversation
The ament_cmake_nose package doesn't exist anymore in ROS Jazzy. New tests are anyway mostly written for pytest, so let's simply switch to that. Pytest should be able to execute the existing tests (they are implemented using `unittest`), so no further changes should be necessary.
The macro was renamed and the old `_interfaces` doesn't work anymore with ROS Jazzy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes that were needed to build the package with ROS Jazzy (Ubuntu 24.04):
ament_export_interfacestoament_export_targets.ament_cmake_pytestinstead ofament_cmake_nose(which doesn't exist anymore). Existing tests work with pytest as well, so no need for further modifications.