fix: unary op shorthand unsupported (#142)

Unary ops should support single args (shorthand) as well as arrays with just a single element. Signed-off-by: Todd Baert <[email protected]>
open-feature · May 23, 2024 · 946ffc4 · 946ffc4
1 parent cc2f5a1
commit 946ffc4
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 11 deletions.
diff --git a/json/targeting.json b/json/targeting.json
@@ -285,12 +285,19 @@
       }
     },
     "unaryOp": {
-      "type": "array",
-      "minItems": 1,
-      "maxItems": 1,
-      "items": {
-        "$ref": "#/definitions/args"
-      }
+      "anyOf": [
+        {
+          "type": "array",
+          "minItems": 1,
+          "maxItems": 1,
+          "items": {
+            "$ref": "#/definitions/args"
+          }
+        },
+        {
+          "$ref": "#/definitions/args"
+        }
+      ]
     },
     "unaryRule": {
       "title": "Unary Operation",

diff --git a/json/targeting.yaml b/json/targeting.yaml
@@ -233,11 +233,13 @@ definitions:
           of arguments.
         $ref: "#/definitions/associativeOp"
   unaryOp:
-    type: array
-    minItems: 1
-    maxItems: 1
-    items:
-      $ref: "#/definitions/args"
+    anyOf:
+    - type: array
+      minItems: 1
+      maxItems: 1
+      items:
+        "$ref": "#/definitions/args"
+    - "$ref": "#/definitions/args"
   unaryRule:
     title: Unary Operation
     description: Any primitive JSONLogic operation with 1 operands.

diff --git a/json/test/positive/basic-json-ops.json b/json/test/positive/basic-json-ops.json
@@ -19,6 +19,7 @@
           {"!=" : [1, 2]},
           {"!==" : [1, 2]},
           {"!": [true]},
+          {"!": true},
           {"!!": ["0"] },
           {"or": [true, false]},
           {"or":[false, 0, "a"]},