-
Notifications
You must be signed in to change notification settings - Fork 76
fix: tests/flagd version to get module correctly #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sivchari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses dependency resolution issues within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies in go.mod and go.sum. The main change is updating the version of the tests/flagd module, which is a good practice to move away from the v0.0.0 placeholder. The other changes are minor version bumps for various golang.org/x packages. My main feedback is regarding the Go version specified in go.mod, which could be made less restrictive to improve compatibility for library consumers.
|
Hey @sivchari. Thank you for your PR but it doesn't resolve the root of the issue. The main thing is that the library should not be present there at all. e2e probably should have its own go.mod with replace to flagd provider and those tests packages. It's a bit messy because of go work. Could you please try that? Please make sure that go.mod uses go 1.24.0. We can't bump it as we promise to support it. |
Signed-off-by: sivchari <[email protected]>
9fbf420 to
24851c1
Compare
|
Hi @erka , it's make sensed to me. Updated it :) |
|
Please use go 1.24.0 in that new go.mod |
go mod tidy -go=1.24.0
go: github.com/docker/compose/[email protected] requires [email protected], but 1.24.0 is requestedThat’s unfortunate. I guess we could keep it at 1.24.9 there. |
|
As you said, we should use 1.24.9. |
This PR
Related Issues
Fixes #805
Notes
Follow-up Tasks
How to test