Skip to content

Conversation

@sivchari
Copy link

This PR

  • Fix tests/flagd version to get it correctly
  • Remain replace directive

Related Issues

Fixes #805

Notes

Follow-up Tasks

How to test

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sivchari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses dependency resolution issues within the providers/flagd module by updating the Go language version and several key module dependencies. The primary goal is to ensure that the tests/flagd module is correctly retrieved and integrated, resolving a previously identified problem.

Highlights

  • Go Version Update: The Go language version for the module has been updated from 1.24.0 to 1.24.9.
  • Dependency Version Bump: The github.com/open-feature/go-sdk-contrib/tests/flagd module dependency has been updated from v0.0.0 to v1.6.0 to correctly resolve the module.
  • Indirect Dependency Updates: Several indirect golang.org/x dependencies, including golang.org/x/net, golang.org/x/sync, golang.org/x/sys, golang.org/x/term, and golang.org/x/text, have been updated to newer versions.
  • go.sum Updates: The go.sum file has been updated to reflect the new checksums for the bumped dependencies, including github.com/containerd/containerd/v2.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in go.mod and go.sum. The main change is updating the version of the tests/flagd module, which is a good practice to move away from the v0.0.0 placeholder. The other changes are minor version bumps for various golang.org/x packages. My main feedback is regarding the Go version specified in go.mod, which could be made less restrictive to improve compatibility for library consumers.

@erka
Copy link
Member

erka commented Dec 22, 2025

Hey @sivchari.

Thank you for your PR but it doesn't resolve the root of the issue. The main thing is that the library should not be present there at all. e2e probably should have its own go.mod with replace to flagd provider and those tests packages. It's a bit messy because of go work. Could you please try that? Please make sure that go.mod uses go 1.24.0. We can't bump it as we promise to support it.

@sivchari sivchari force-pushed the fix-unknown-revision branch from 9fbf420 to 24851c1 Compare December 22, 2025 07:12
@sivchari sivchari changed the title fix tests/flagd version to get module correctly fix: tests/flagd version to get module correctly Dec 22, 2025
@sivchari
Copy link
Author

Hi @erka , it's make sensed to me. Updated it :)

@erka
Copy link
Member

erka commented Dec 22, 2025

Please use go 1.24.0 in that new go.mod

@erka
Copy link
Member

erka commented Dec 22, 2025

go mod tidy -go=1.24.0
go: github.com/docker/compose/[email protected] requires [email protected], but 1.24.0 is requested

That’s unfortunate. I guess we could keep it at 1.24.9 there.

@sivchari
Copy link
Author

As you said, we should use 1.24.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flagd] providers/flagd v0.3.1 got go complaint "invalid version: unknown revision tests/flagd/v0.0.0"

5 participants