Skip to content

fix: add logger to client #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sivchari
Copy link

@sivchari sivchari commented Apr 2, 2025

This PR

Added logger field to client to output to somewhere in the future.

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: sivchari <[email protected]>
@sivchari sivchari requested a review from a team as a code owner April 2, 2025 09:51
@sivchari sivchari changed the title add logger to client fix: add logger to client Apr 16, 2025
@beeme1mr beeme1mr requested a review from toddbaert April 29, 2025 16:22
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (58a2a17) to head (451ec0c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
openfeature/client.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   88.13%   88.08%   -0.06%     
==========================================
  Files          14       14              
  Lines        1408     1410       +2     
==========================================
+ Hits         1241     1242       +1     
- Misses        143      144       +1     
  Partials       24       24              
Flag Coverage Δ
e2e 88.08% <66.66%> (-0.06%) ⬇️
unit 88.08% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants