Skip to content

test: fix tests - add missing cleanup and wait. #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

alan-kut
Copy link
Contributor

This PR

Fix tests: add missing cleanup and wait.

Missing cleanup caused test failures if the tests are executed in a different order.
Missing wait caused issues when the provider wasn't initializes before the test executed.

@alan-kut alan-kut requested a review from a team as a code owner April 29, 2025 13:10
@alan-kut alan-kut changed the title Fix tests: add missing cleanup and wait. test: fix tests - add missing cleanup and wait. Apr 29, 2025
@toddbaert toddbaert merged commit 640448d into open-feature:main Apr 30, 2025
7 of 8 checks passed
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (05a6d97) to head (ae6b54f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files          14       14           
  Lines        1408     1408           
=======================================
  Hits         1241     1241           
  Misses        143      143           
  Partials       24       24           
Flag Coverage Δ
e2e 88.13% <ø> (ø)
unit 88.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toddbaert
Copy link
Member

Thanks @alan-kut !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants