Skip to content

[Fix] Correctly process compile.disable in config #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2025
Merged

[Fix] Correctly process compile.disable in config #1674

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b63fd0d
mmeng can now recognize `compile.disable` now.
MGAMZ Oct 26, 2025
fce4f85
Fix logical error and improve readability
MGAMZ Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mmengine/_strategy/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,8 @@ def compile_model(
Returns:
nn.Module: Compiled model.
"""
if isinstance(compile, bool) and not compile:
if isinstance(compile, bool) and not compile or \
isinstance(compile, dict) and not compile.get('disable', False):
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition logic is inverted. When disable=True, not compile.get('disable', False) evaluates to False, preventing the early return. The condition should be compile.get('disable', False) (without not) to return the model when disable is True.

Suggested change
isinstance(compile, dict) and not compile.get('disable', False):
isinstance(compile, dict) and compile.get('disable', False):

Copilot uses AI. Check for mistakes.
return model

assert digit_version(TORCH_VERSION) >= digit_version('2.0.0'), (
Expand Down