Skip to content

Conversation

LeoXing1996
Copy link
Collaborator

@LeoXing1996 LeoXing1996 commented Jan 2, 2022

Time cost comparison

Model Offline Offline w save_npz online
SAGAN-128 14:56.74 6:57.43 5:19.90

This feature can greatly speed up sampling result saving and metric evaluation.

@LeoXing1996 LeoXing1996 requested a review from plyfager January 2, 2022 14:57
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #201 (7ca9b49) into master (55c9a42) will decrease coverage by 0.33%.
The diff coverage is 49.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   75.60%   75.27%   -0.34%     
==========================================
  Files         128      129       +1     
  Lines        8933     9051     +118     
  Branches     1783     1807      +24     
==========================================
+ Hits         6754     6813      +59     
- Misses       1729     1786      +57     
- Partials      450      452       +2     
Flag Coverage Δ
unittests 75.27% <49.19%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/core/evaluation/evaluation.py 7.78% <6.25%> (-0.34%) ⬇️
mmgen/datasets/file_dataset.py 94.64% <94.64%> (ø)
mmgen/datasets/__init__.py 100.00% <100.00%> (ø)
mmgen/datasets/pipelines/formatting.py 98.24% <100.00%> (+0.03%) ⬆️
...chitectures/stylegan/generator_discriminator_v1.py 88.70% <0.00%> (-1.13%) ⬇️
...chitectures/stylegan/generator_discriminator_v2.py 87.77% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c9a42...7ca9b49. Read the comment docs.

save_npz (bool, optional): Whether save the generated images to a npz
file named 'samples_{NUM_IMAGES}x{H}x{W}x{NUM_CHANNELS}.npz' If
true, dataset will be build upon npz file instead of image files.
Defaults to True.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults to False

@plyfager
Copy link
Collaborator

A description to clarify why you pull this request is supposed to be offered. Also, our documentation should be updated accordingly.

@zengyh1900 zengyh1900 added this to the Backlog milestone Oct 12, 2022
@zengyh1900 zengyh1900 added community/help wanted extra attention is needed kind/feature request new feature/model/datasets/config etc. labels Oct 12, 2022
LeoXing1996 pushed a commit to LeoXing1996/mmgeneration that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/help wanted extra attention is needed kind/feature request new feature/model/datasets/config etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants