bugfix: Setting OMPI_MPI_THREAD_LEVEL to a value different than requested crashes #13211
Conversation
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
4 times, most recently
from
b71461f to
b481893
Compare
| @@ -46,7 +47,8 @@ PROTOTYPE INT init(INT_OUT argc, ARGV argv) | |||
|
|
|||
| if (NULL != (env = getenv("OMPI_MPI_THREAD_LEVEL"))) { | |||
| required = atoi(env); | |||
| if (required < MPI_THREAD_SINGLE || required > MPI_THREAD_MULTIPLE) { | |||
| if (required != MPI_THREAD_SINGLE && required != MPI_THREAD_FUNNELED && | |||
| required != MPI_THREAD_SERIALIZED && required != MPI_THREAD_MULTIPLE) { | |||
There was a problem hiding this comment.
Just curious: what's the need for this? Doesn't MPI specify the relationship between all the MPI_THREAD_* values such that < SINGLE and > MULTIPLE is guaranteed to be invalid?
There was a problem hiding this comment.
In the new MPI ABI, values are still ordered but not consecutive, so users could use one of the invalid intermediate values.
https://github.com/mpi-forum/mpi-abi-stubs/blob/e89a80017a3fe9a05d903ced2564c6342d678165/mpi.h#L334
There was a problem hiding this comment.
Actually, this is worth a comment for those of us who look at this code and wonder why it is this way (and to make sure someone doesn't mistakenly return it to <SINGLE || >MULTIPLE someday). Can you please add comments in these places and describe that checking each individual value is required because of ABI? Thanks.
ompi/mpi/c/init_thread.c.in
Outdated
| */ | ||
| if (NULL != (env = getenv("OMPI_MPI_THREAD_LEVEL"))) { | ||
| int env_required = atoi(env); | ||
| err_arg_required = err_arg_required || |
There was a problem hiding this comment.
My biggest concern here is that the user is required to know the valid thread level values as defined in the MPI ABI header. We should keep doing what we do right now, aka 0-3, and use a shift operation to convert it to the ABI value env_required = (1 << (10 + atoi(env)));
There was a problem hiding this comment.
For now, the valid values are still [0-3] (because our internal ABI is not the same as the standardized ABI (yet?), I'll add this consideration to the comment requested by Jeff so we don't forget when the time comes.
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
from
b481893 to
1a0d2f7
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 1a0d2f7: review comments
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
`requested` in `MPI_Init_thread` would invoke the error handler, even though it is an useful override in some threaded library use cases. Signed-off-by: Aurelien Bouteiller <[email protected]>
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
from
1a0d2f7 to
8ad7579
Compare
Setting OMPI_MPI_THREAD_LEVEL to a value different than
requestedinMPI_Init_threadwould invoke the error handler, even though it is an useful override in some threaded library use cases.