v6.0.x: coll/acoll: Fixes to acoll component #13614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
previously requested changes
Jan 6, 2026
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Please do not cherry pick merge commits.
jsquyres
changed the title
Adds some bug fixes to the acoll component. - gather is corrected to work for non-zero root ranks when three stage algorithm is used. - Busy waits in shared memory bcast and barrier are changed to avoid random hangs. - Overrides with command line arguments are properly taken care of in bcast algorithm selection. - Multinode path of reduce and allreduce is fixed to use the hierarchical algorithms of acoll. - Compile time warnings are removed. Signed-off-by: Nithya V S <[email protected]> (cherry picked from commit 12f6838)
Changes in formatting to adhere to ompi coding style. Signed-off-by: Nithya V S <[email protected]> (cherry picked from commit a3d2d4a)
Fixes a condition for freeing temporary buffer in acoll reduce. Signed-off-by: Nithya V S <[email protected]> (cherry picked from commit 6838054)
amd-nithyavs
force-pushed
the
6Jan2026_6.0_acoll_fixes
branch
from
efd85b5 to
a037a7e
Compare
Contributor
Author
Cherry-picked from the PR. Please let me know if it is fine now. |
jsquyres
dismissed
their stale review
Thanks! I'll dismiss my NACK, and let others who are familiar with acoll do the actual review.
edgargabriel
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some bug fixes to the acoll component.
Cherry-picked from #13575