feat: add pre-commit hook support #1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevilledev
force-pushed
the
feat/pre-commit
branch
from
ff1ef48 to
5f85c11
Compare
jalseth
reviewed
Mar 1, 2025
| @@ -73,6 +73,15 @@ jobs: | |||
| - name: unit test | |||
| run: make test | |||
|
|
|||
| - name: setup python | |||
There was a problem hiding this comment.
Why does the conftest repo need to install this in the PR flow?
There was a problem hiding this comment.
This is not a requirement, but without it the workflow will use the Python version that's bundled with the CI runner to install pre-commit. The Python version might change and possibly cause issues in the pipeline. Not sure if there's already loose dependencies like this to the CI runner binaries/versions?
thevilledev
force-pushed
the
feat/pre-commit
branch
3 times, most recently
from
82f5e16 to
40d784f
Compare
thevilledev
changed the title
|
I'll add a separate "conftest-test" and "conftest-verify" hooks to cover both cases. Will mark this as a draft until done later today! EDIT: done :) |
Add pre-commit integration to validate configurations against OPA policies: - Create .pre-commit-hooks.yaml with conftest test/verify hook configs - Add pre-commit hook tests using bats - Install pre-commit in CI workflow Signed-off-by: Ville Vesilehto <[email protected]>
thevilledev
force-pushed
the
feat/pre-commit
branch
from
40d784f to
cb3ad26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-commit integration to validate configurations against OPA policies:
Fixes #1011