Add prefer-value-in-head option to count interpolated string as scalar
#1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # to the head, and not expressions or functions | ||
| only-scalars: false | ||
| # when set to true, counts interpolated strings as a scalar value, and will suggest | ||
| # moving them to the head even when `only-scalars` is true |
Contributor
There was a problem hiding this comment.
Suggested change
| # moving them to the head even when `only-scalars` is true | |
| # moving them to the head even when `only-scalars` is true |
charlieegan3
approved these changes
Jan 12, 2026
charlieegan3
force-pushed
the
prefer-interpolated-in-head
branch
from
c8f2534 to
a3964ee
Compare
anderseknert
force-pushed
the
prefer-interpolated-in-head
branch
from
a3964ee to
a64c40d
Compare
I noticed in some rule I worked on that Regal didn't flag this, which was right given that interpolated strings aren't exactly scalar values. But I _do_ want to have Regal recommend moving them to the head assignment when possible, while keeping the `only-scalars` option set as `true`. This PR adds a new `include-interpolated` option to allow this precisely, and makes it enabled in our own settings. Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
prefer-interpolated-in-head
branch
from
a64c40d to
cc99522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in some rule I worked on that Regal didn't flag this, which was right given that interpolated strings aren't exactly scalar values. But I do want to have Regal recommend moving them to the head assignment when possible, while keeping the
only-scalarsoption set astrue. This PR adds a newinclude-interpolatedoption to allow this precisely, and makes it enabled in our own settings.