Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Error Handling to Prevent Exit, Crashes and Memory Leaks #1929

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

Improve Error Handling to Prevent Exit, Crashes and Memory Leaks #1929

wants to merge 40 commits into from
+1,610 −805

Commits on Sep 13, 2024

  1. Bump version string; update release and security notes. 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    16b1a32 View commit details
    Browse the repository at this point in the history

  2. Complete release notes 

    Signed-off-by: Spencer Wilson <[email protected]>
    @SWilson4
    SWilson4 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e6d9a2f View commit details
    Browse the repository at this point in the history

  3. Remove references to profiling, liboqs-java, and liboqs-dotnet 

    Signed-off-by: Spencer Wilson <[email protected]>
    @SWilson4
    SWilson4 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cda3e35 View commit details
    Browse the repository at this point in the history

  4. Bump SOVERSION 

    Signed-off-by: Spencer Wilson <[email protected]>
    @SWilson4
    SWilson4 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3b2cd83 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. [open-quantum-safe#1823] replace malloc/calloc/strdup/free with opens… 

    …sl allocator

Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    e4d0560 View commit details
    Browse the repository at this point in the history

  2. [open-quantum-safe#1823] update memory allocator for copy_from_upstream 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    125027e View commit details
    Browse the repository at this point in the history

  3. [open-quantum-safe#1823] format code 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0d35a14 View commit details
    Browse the repository at this point in the history

  4. [open-quantum-safe#1823] Use OpenSSL Memory Allocator for BIKE, Frodo… 

    …KEM, and NTRUPrime

Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    7f3fe9c View commit details
    Browse the repository at this point in the history

  5. [open-quantum-safe#1823] Add Comments for Doxygen 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d544770 View commit details
    Browse the repository at this point in the history

  6. sig_stfl build fix 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    e177d16 View commit details
    Browse the repository at this point in the history

  7. fix ptrdiff_t failure 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d73b469 View commit details
    Browse the repository at this point in the history

  8. include openssl/crypto.h and resolve conflict varible for ntru 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    9e15107 View commit details
    Browse the repository at this point in the history

  9. Add openssl version check to fix build error 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    a83958b View commit details
    Browse the repository at this point in the history

  10. fix implicit conversion for diff 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    369a268 View commit details
    Browse the repository at this point in the history

  11. fix build for tests 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    e24b16a View commit details
    Browse the repository at this point in the history

  12. Fix build for tests 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    fdacd10 View commit details
    Browse the repository at this point in the history

  13. Fix build for OQS_DLOPEN_OPENSSL 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0c99451 View commit details
    Browse the repository at this point in the history

  14. Fix build failure 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    a90603f View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Error Handling 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    40586f8 View commit details
    Browse the repository at this point in the history

  2. Add NULL check for AES 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    b8236b1 View commit details
    Browse the repository at this point in the history

  3. remove io for better performance during failure. add log later. 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    fec2cdf View commit details
    Browse the repository at this point in the history

  4. Add NULL check for AES 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    5e0d03b View commit details
    Browse the repository at this point in the history

  5. fix OQS_OPENSSL_GUARD failure 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0c2345b View commit details
    Browse the repository at this point in the history

  6. Fix potential memory leak for do_hash 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    7f6ea1b View commit details
    Browse the repository at this point in the history

  7. Fix potential memory leak for sha2_256_init 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    c6ace19 View commit details
    Browse the repository at this point in the history

  8. Fix potential memory leak for SHA2_sha512_inc 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    3fa49f1 View commit details
    Browse the repository at this point in the history

  9. format code 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    8ab2e63 View commit details
    Browse the repository at this point in the history

  10. Fix NULL check for ossl_sha3.c 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    1089458 View commit details
    Browse the repository at this point in the history

  11. Add NULL check for rand 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    2780fe9 View commit details
    Browse the repository at this point in the history

  12. format code 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    2e6facb View commit details
    Browse the repository at this point in the history

  13. Add NULL check for common 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    148b11b View commit details
    Browse the repository at this point in the history

  14. fix build failure 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    9bb0db9 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. remove OQS_MEM_free 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    00a9689 View commit details
    Browse the repository at this point in the history

  2. remove OQS_MEM_free 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c02c48c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Add allocator check in tests/test_code_conventions.py 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c4b6587 View commit details
    Browse the repository at this point in the history

  2. format code 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1fc3fee View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. revert changes back for CMakeLists.txt, RELEASE.md and SECURITY.md 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a77e2af View commit details
    Browse the repository at this point in the history

  2. revert changes back for RELEASE.md and SECURITY.md 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    050a561 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'open-quantum-safe:main' into pr_shan_error_handling

    @songlingatpan
    songlingatpan authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    97f283f View commit details
    Browse the repository at this point in the history

  2. revert back to abort() in OQS_MEM_cleanse 

    Signed-off-by: Songling Han <[email protected]>
    @songlingatpan
    songlingatpan committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8339bd6 View commit details
    Browse the repository at this point in the history