Skip to content

Use trunk version of rxcpp. Resolves #122 - #127

Merged
mxgrey merged 3 commits into
mainfrom
arjo/update_rxcpp
Sep 30, 2021
Merged

Use trunk version of rxcpp. Resolves #122#127
mxgrey merged 3 commits into
mainfrom
arjo/update_rxcpp

Conversation

@arjo129

@arjo129 arjo129 commented Sep 27, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Arjo Chakravarty arjo@openrobotics.org

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@mxgrey

mxgrey commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

We should make sure to incorporate the changes in this RxCpp PR.

@arjo129 arjo129 linked an issue Sep 27, 2021 that may be closed by this pull request
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@codecov

codecov Bot commented Sep 29, 2021

Copy link
Copy Markdown

Codecov Report

Merging #127 (69b4edc) into main (78e85e6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   21.44%   21.40%   -0.04%     
==========================================
  Files         210      840     +630     
  Lines       16958    67896   +50938     
  Branches     8071    32304   +24233     
==========================================
+ Hits         3636    14532   +10896     
- Misses       9413    37696   +28283     
- Partials     3909    15668   +11759     
Flag Coverage Δ
tests 21.40% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._rxcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-observer.hpp
...f_fleet_adapter/test/phases/MockAdapterFixture.cpp
....0/Rx/v2/src/rxcpp/operators/rx-combine_latest.hpp
...tw3k/rmf_ros2/rmf_fleet_adapter/test/test_Task.cpp
...ter/src/rmf_fleet_adapter/phases/WaitForCharge.cpp
...eet_adapter/src/rmf_fleet_adapter/phases/Utils.cpp
...mf_fleet_adapter/rmf_rxcpp/test/test_Transport.cpp
...i28gjtw3k/rmf_ros2/rmf_fleet_adapter/test/main.cpp
...ffic_ros2/src/rmf_traffic_ros2/blockade/Writer.cpp
...p/RxCpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-map.hpp
... and 1040 more

@mxgrey
mxgrey self-requested a review September 30, 2021 02:08

@mxgrey mxgrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting these files updated!

@mxgrey
mxgrey merged commit 081b3e3 into main Sep 30, 2021
@mxgrey
mxgrey deleted the arjo/update_rxcpp branch September 30, 2021 07:35
arjo129 added a commit that referenced this pull request Oct 12, 2021
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
aaronchongth pushed a commit that referenced this pull request May 6, 2025
Signed-off-by: Xi Yu Oh <xiyu@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump RxCpp Version up.

2 participants