Remove explicit Qt dependency from rviz plugins #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Closes #87, depends on upstream
rviz_commonPR ros2/rviz#1635.Fix builds for rolling.
We should probably wait for the upstream PR to be merged and a Rolling sync to happen before merging this.
Fix applied
Since we want to keep this building with both Rolling, Lyrical and future versions, but also not break the old versions, don't explicitly depend on Qt5 or Qt6 and just depend on
rviz_commoninstead, which willfind_packagethe right version of Qt depending on the platform.Seems to build and run correctly in my local tests on a Noble + Jazzy and Noble + Rolling machine with the linked
rviz2branch to build from source.GenAI Use
We follow OSRA's policy on GenAI tools