-
Notifications
You must be signed in to change notification settings - Fork 16
Adds abort signal to requests #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
===========================================
+ Coverage 99.75% 100.00% +0.24%
===========================================
Files 11 11
Lines 404 430 +26
Branches 56 62 +6
===========================================
+ Hits 403 430 +27
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enables request abortion using AbortSignal in all transports. The change ensures requests can be cancelled, prevents memory leaks and improves user experience by rejecting requests that are no longer relevant. Implements AbortError class to differentiate RPC errors from aborts. Ran `npm i baseline-browser-mapping@latest -D` to update browser mappings, and `npm audit fix` to fix 3 vulnerabilities (1 low, 1 moderate, 1 high).
|
Thanks for the PR !! Going to leave this here, early haven't fully reviewed the PR, but I'd say a few off the top of my head comments.
I'll comment further when I get a chance to go over it more in depth hopefully sometime this or early next week |
|
Installing baseline is to get rid of that
It's just a couple more tests to complete missing coverage, nothing else. |
Fixes #367
AbortErrorto differentiate RPC errors from aborts.npm i baseline-browser-mapping@latest -Dto update browser mappings (fixes warnings when running tests)npm audit fixto fix 3 vulnerabilities (1 low, 1 moderate, 1 high).fetcheris missing, and a test to coverindex.tsexports.