fix(fsrs): achieve state preservation parity between Forget and Rollback#66
Merged
Conversation
…state in Forget - Copy RemainingSteps from ReviewLog when rolling back a card - Record pre-forget State, Due, Stability, Difficulty, ScheduledDays and RemainingSteps in Forget ReviewLog - Preserve card LastReview across forget
…state capture - Add learning-state rollback test asserting RemainingSteps restoration - Update Forget tests to assert pre-forget state in ReviewLog - Add tests for scheduled-days computation and pre-forget log fields
Member
Author
Thank you!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR achieves state preservation parity between the Forget and Rollback operations in the FSRS (Free Spaced Repetition Scheduler). The Forget function now captures the card's full pre-forget state in the review log, and the Rollback function now restores RemainingSteps from the log, ensuring both operations consistently preserve and restore all relevant state information.
Bug Description
Changes Made
result.RemainingSteps = log.RemainingStepsto restore RemainingSteps from the ReviewLog during rollback.Testing
Related Issues
Fixes #65
Breaking Changes
None — These are bug fixes correcting incorrect behavior. The public API signatures remain unchanged.