-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus Receiver test for label_name_length_limit configuration #6362
Merged
codeboten
merged 14 commits into
open-telemetry:main
from
open-o11y:prom-receiver-label-name-length
Nov 23, 2021
Merged
Add Prometheus Receiver test for label_name_length_limit configuration #6362
codeboten
merged 14 commits into
open-telemetry:main
from
open-o11y:prom-receiver-label-name-length
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishiy
approved these changes
Nov 19, 2021
Aneurysm9
approved these changes
Nov 19, 2021
alolita
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Nov 22, 2021
codeboten
approved these changes
Nov 23, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:prometheus
Prometheus related issues
comp: receiver
Receiver
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR depends on #6150 , commit 68e77b6 adds the test for label_name_length_limit
Adds
TestLabelNameLimitConfig
to test label_name_length_limit configuration for Prometheus receiverTestLabelNameLimitConfig
:Sets the label_name_length_limit for Prometheus receiver
Tests the following two scenarios:
Link to tracking Issue:
PR 2/3 for #5997 . Following PR will add test for label_value_length_limit