[exporter][batching][chore] record batch creation time #12752
+24
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
changed the title
sfc-gh-sili
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12752 +/- ##
==========================================
- Coverage 91.45% 91.45% -0.01%
==========================================
Files 483 483
Lines 26605 26604 -1
==========================================
- Hits 24332 24331 -1
Misses 1791 1791
Partials 482 482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
reviewed
Mar 28, 2025
Comment on lines
+194
to
+197
| if !forceFlush && time.Since(qb.currentBatch.created) < qb.cfg.FlushTimeout { | ||
| qb.currentBatchMu.Unlock() | ||
| return | ||
| } |
There was a problem hiding this comment.
This mean that we no longer do flush every FlushTimeout, but somewhere between [FlushTimeout, 2*FlushTimeout]
There was a problem hiding this comment.
Agreed. Is changing to a Ticker needed?
There was a problem hiding this comment.
I see what you mean.
I was trying to use a single time keeper for all batches, but if we want to control the flush timeout more precisely, we could keep a separate timer for each batch instead
sfc-gh-sili
force-pushed
the
sili-metadata-key1
branch
from
145bde3 to
4b42af5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Link to tracking issue
#12473
Testing
Documentation