3267 cmake googletest #3290
Draft
3267 cmake googletest #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the precompiled shared libraries is not recommended, as for opentelemetry-cpp, some tests end up failing. Fixes: 3267
It is need to update the git submdule, and move the code to install the opentelemetry-cpp build dependencies to the ci/setup_ci_environment.sh script.
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
|
@santiagorr This PR is draft, and CI is failing. Are you still working on it ? |
|
marcalff left a comment (open-telemetry/opentelemetry-cpp#3290)
@santiagorr This PR is draft, and CI is failing. Are you still working on it ?
Yeah, I am aware CI is failing. I still plan to complete this work, but
it is currently stalled.
Thanks for the ping.
|
dbarker
reviewed
Apr 3, 2025
| endif() | ||
| elseif(WIN32) | ||
|
|
||
| if(WIN32) |
There was a problem hiding this comment.
The general approach looks good - 1) try to find an installed gtest cmake package, 2) build the submodule for gtest if no package is found.
We should try to find the gtest package first on all platforms though - not just windows. The cmake install github workflow has jobs that install gtest with conan on Ubuntu and MacOS and we should ensure those packages are found instead of building the submodule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3267
Changes
Build googletest from the source code along with opentelemetry-cpp, as it is recommended by googletest. Relying on precompiled shared libraries yields to some errors during testing. Using ExternalProject_add() (in favor of alternatives as FetchContent) since googletest is found as a third-party submodule, and it is easier to "integrate" in distros like debian, that ship googletest source code as a package.
I am not able to test how this builds on windows.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes -> I think these are trivial changes, but I can describe them in CHANGELOG.md, if you think that helps.