Skip to content

Add messaging wrappers to support lightweight manual instrumentation #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

Cirilla-zmh
Copy link
Member

Description:

< Describe what is being changed or added.
Ex. Bug fix - Describe the bug and how this fixes it.
Ex. Feature addition - Describe what this provides and why. >

Existing Issue(s):

< Link any applicable issues. >

Testing:

< Describe what testing was performed and any tests were added. >

Documentation:

< Describe the documentation added.
Please be sure to modify relevant existing documentation if needed. >

Outstanding items:

< Anything that these changes are intentionally missing
that will be needed or can be helpful in the future. >

Copy link

linux-foundation-easycla bot commented Mar 19, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@Cirilla-zmh
Copy link
Member Author

Cirilla-zmh commented Mar 20, 2025

Several suggestions from trask:

  • Remove the useless Response API.
  • Add one more code owner.
  • Should not directly convert a particular non-checked exception to an Exception class object.
  • Replace SpanCustomizer with AttributeExtractor in instrumentation. (Users could just access span by Span.current())
  • Add a more clear demo.

Thanks for @trask !

@Cirilla-zmh
Copy link
Member Author

@trask
Hi Trask, I've completed this PR draft and add a test for kafka-clients, I think you'll be familiar with it.

Tests for mns-clients and api itself are not implemented in view of possible migration from java-contrib to java-instrumentation. (Add an integration test here are struggle...)

Looking forward to your response and have nice days on KubeCon EU!

@Cirilla-zmh
Copy link
Member Author

BTW, please ignore the build failure caused by mns. Our sdk of 1.3.0 hasn't been released yet and we will release it soon.

@Cirilla-zmh Cirilla-zmh changed the title [WIP] Add messaging wrappers to support lightweight manual instrumentation Add messaging wrappers to support lightweight manual instrumentation Apr 16, 2025
```xml
<dependency>
<groupId>io.opentelemetry.contrib</groupId>
<artifactId>opentelemetry-messaging-wrappers-api</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add following version like other modules? https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/inferred-spans#usage

    <version>{latest version}</version>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #1855 for newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants