Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert servlet tests to java #12013

Merged
merged 43 commits into from
Sep 24, 2024
Merged

convert servlet tests to java #12013

merged 43 commits into from
Sep 24, 2024

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Aug 14, 2024 •
edited by jaydeluca
Loading

servlet 5 is very similar to 3 - will do that in a follow-up PR

related to #7195

@zeitlinger zeitlinger self-assigned this Aug 14, 2024
@zeitlinger zeitlinger requested a review from a team August 14, 2024 12:50
@zeitlinger zeitlinger mentioned this pull request Aug 14, 2024
Open
@zeitlinger zeitlinger force-pushed the convert-servlet-tests-to-java branch 3 times, most recently from 80e28a9 to 34035ee Compare August 23, 2024 12:52
@zeitlinger
Copy link
Member Author

@steverao can you take a look?

@zeitlinger zeitlinger force-pushed the convert-servlet-tests-to-java branch from ee06c0a to 6f5e60b Compare August 26, 2024 07:48
@zeitlinger
Copy link
Member Author

@laurit @steverao please check again

@zeitlinger
Copy link
Member Author

@laurit please check again

@zeitlinger zeitlinger force-pushed the convert-servlet-tests-to-java branch from 4832af6 to 00d5b85 Compare August 30, 2024 16:48
@zeitlinger
Copy link
Member Author

zeitlinger commented Sep 2, 2024 •
edited
Loading

@zeitlinger some of the review comments I left apply to multiple locations, could you apply the same changes everywhere where the same pattern is used

I hope I found them all now @laurit

@zeitlinger
Copy link
Member Author

@laurit please check again

@laurit laurit merged commit c55cbbe into open-telemetry:main Sep 24, 2024
56 checks passed
@zeitlinger zeitlinger deleted the convert-servlet-tests-to-java branch September 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao steverao left review comments

@jaydeluca jaydeluca jaydeluca approved these changes

@laurit laurit laurit approved these changes

Assignees

@zeitlinger zeitlinger

Labels
area:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeitlinger @laurit @jaydeluca @steverao