Add rules for basic JVM monitoring to intstrumentation/jmx-metrics #12310
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose adding a set of rules for reporting basic JVM metrics (GC, memory, classloaders). I've seen some of these mentioned in the README, though there's no built-in ruleset.
I've created my own basing on another otel project, and maybe this might be useful for others as well? (probably in combination with the rule sets already defined (for tomcat, kafka etc.)). Initially, I kind of expected these to be reported by default, but it turned out otherwise :) Unless there are other mechanisms for funnelling the basic JVM metrics into otel, that are preferable?