Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @WithSpan option to break from existing context #13112

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add @WithSpan option to break from existing context #13112

wants to merge 13 commits into from
+143 −4

Conversation

xiepuhuan
Copy link
Contributor

Related to #1036

@xiepuhuan xiepuhuan requested a review from a team as a code owner January 27, 2025 07:56
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Jan 27, 2025
@xiepuhuan
Copy link
Contributor Author

xiepuhuan commented Jan 27, 2025 •
edited
Loading

The smoke test of grpc failed. Because I modified the @WithSpan annotation of instrumentation-annotations, and the grpc smoke test image uses @WithSpan, I need to rely on the new smoke test grpc image version.
What should I do? @trask help me

@laurit
Copy link
Contributor

laurit commented Jan 27, 2025

The smoke test of grpc failed. Because I modified the @WithSpan annotation of instrumentation-annotations, and the grpc smoke test image uses @WithSpan, I need to rely on the new smoke test grpc image version. What should I do? @trask help me

You got it wrong. The test is failing because after your changes the instrumentation does not work any more for old version of the @WithSpan annotation that does not have the withParent attribute. This is a bug in your PR.

@xiepuhuan
Copy link
Contributor Author

xiepuhuan commented Jan 28, 2025 •
edited
Loading

The smoke test of grpc failed. Because I modified the @WithSpan annotation of instrumentation-annotations, and the grpc smoke test image uses @WithSpan, I need to rely on the new smoke test grpc image version. What should I do? @trask help me

You got it wrong. The test is failing because after your changes the instrumentation does not work any more for old version of the @WithSpan annotation that does not have the withParent attribute. This is a bug in your PR.

@laurit Thank you for your reply. I want to use reflection to determine whether the withParent method exists to fix this bug and achieve backward compatibility. Do you have any suggestions for this?

@xiepuhuan xiepuhuan requested a review from trask February 12, 2025 02:18
@trask trask changed the title Add withParent option to annotation @WithSpan Add @WithSpan option to break from existing context Feb 13, 2025
@xiepuhuan xiepuhuan requested a review from laurit February 15, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask Awaiting requested review from trask

@laurit laurit Awaiting requested review from laurit

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiepuhuan @laurit @trask