Resolve CodeQL zip slip warning #13183
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Feb 4, 2025
| @@ -303,8 +303,16 @@ private URL findJarResource(String name) { | |||
| private URL getJarEntryUrl(JarEntry jarEntry) { | |||
| if (jarEntry != null) { | |||
| try { | |||
| return new URL(jarBase, jarEntry.getName()); | |||
| } catch (MalformedURLException e) { | |||
| String entryName = jarEntry.getName(); | |||
There was a problem hiding this comment.
The intent of the warning is that when you extract jar entries into a directory and there is a malicious entry that contains .. you may up overwriting something outside of the directory where you were extracting the jar. Imo the codeql warning here isn't justified as the jar entry name isn't really used for an io operation. I think it should be possible to circumvent this. Since we look up the JarEntry by name we don't need to use getName() but can remember the name that we used to look it up.
There was a problem hiding this comment.
An alternative implementation #13193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/opentelemetry-java-instrumentation/security/code-scanning/132