Ensure tilde$1 onExit is run in correct order #13360
Open
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
masonedmison
force-pushed
the
add-finalizer-to-future
branch
3 times, most recently
from
dbdb128 to
6b91cd1
Compare
masonedmison
force-pushed
the
add-finalizer-to-future
branch
2 times, most recently
from
ebd0c56 to
0a6dbbf
Compare
masonedmison
force-pushed
the
add-finalizer-to-future
branch
from
0a6dbbf to
1184b41
Compare
masonedmison
commented
Feb 20, 2025
...javaagent/instrumentation/pekkohttp/v1_0/server/route/RouteConcatenationInstrumentation.java
Show resolved
Hide resolved
|
If you guys are happy with this, I can make a similar change to the Akka instrumentation: the same race condition exists within its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13049