build(check-links): remove unnecessary npm install for check-links workflow #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragmaticivan
force-pushed
the
fix-markdown-link-check-with-npx
branch
from
98d5690 to
94316ab
Compare
pragmaticivan
commented
Feb 5, 2025
| @@ -1,4 +1,4 @@ | |||
| name: check-links | |||
| name: "Link Check" | |||
There was a problem hiding this comment.
FYI, also changed the name of the workflow because this one is the only workflow not following this format.
serkan-ozal
approved these changes
Feb 5, 2025
tylerbenson
approved these changes
Feb 6, 2025
|
@pragmaticivan seems that still fails: |
https://www.npmjs.com/package/markdown-link-check @serkan-ozal
|
tylerbenson
added
the
github_actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added by accident, but if the workflow is using npx, it will download the dependency automatically. There is also no
package.jsonat the root of the repository either, which is causing errors in some PRs.