Remove non-generic instrumentations from defaults #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpessers
force-pushed
the
feat/nodejs/update-auto-instrumentation-defaults
branch
from
5ca8656 to
e5c0a54
Compare
wpessers
changed the title
|
I'm honestly content with this list: While not extremely useful, DNS and Net might be relevant for some people and are generic enough that they might be worth keeping as default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the amount of default instrumentations. These are the instrumentations that are initialized by default when a user does not set the
OTEL_NODE_ENABLED_INSTRUMENTATIONSenvironment variable on their lambda function.The current defaults include a lot of instrumentations that are not generic. e.g. the
expressinstrumentation is only useful to users who use theexpress.jsframework in their lambda, but is currently part of the defaults.To start I have reduced the list of defaults to contain:
Having
httpinstrumentation seems like a sensible default, as it is used under the hood by many other packages.What concerns
dnsandnetinstrumentation, I can see a good case for removing those from the defaults as well.dns: Do we need dns lookup etc spans by default?net: Do we need tcp level spans by default?I'm personally leaning towards removing these from defaults as well. Any input here is appreciated!
fixes #1735