Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated code and BC hacks #1099

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Aug 10, 2023

in preparation for RC, removing deprecations and BC hacks so that we have a clean slate for 1.0.0

Fixes #1035
Fixes #1038

in preparation for RC, removing deprecations and BC hacks so that we have a clean slate for 1.0.0
@brettmc brettmc requested a review from a team August 10, 2023 03:17
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1099 (6ea089d) into main (82f0c44) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 6ea089d differs from pull request most recent head 87c5983. Consider uploading reports for the commit 87c5983 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1099      +/-   ##
============================================
- Coverage     83.13%   83.05%   -0.09%     
+ Complexity     2202     2149      -53     
============================================
  Files           282      278       -4     
  Lines          6275     6118     -157     
============================================
- Hits           5217     5081     -136     
+ Misses         1058     1037      -21     
Flag Coverage Δ
7.4 81.66% <ø> (-0.13%) ⬇️
8.0 82.97% <ø> (-0.09%) ⬇️
8.1 83.11% <ø> (-0.09%) ⬇️
8.2 83.11% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/SDK/Common/Time/SystemClock.php 64.28% <ø> (+19.28%) ⬆️
src/SDK/Metrics/MeterProviderBuilder.php 0.00% <ø> (ø)
src/SDK/Resource/ResourceInfoFactory.php 100.00% <ø> (+11.36%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f0c44...87c5983. Read the comment docs.

@brettmc brettmc merged commit 62a14d1 into open-telemetry:main Aug 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove deprecated classes and functions before release candidates remove BC hacks before release candidates
2 participants