Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Lambda Lineage to XRay Trace Header using W3CBaggage #3223

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

liustve
Copy link

@liustve liustve commented Jan 30, 2025

Description

Leaving this PR as a draft Lambda has confirmed they are ready for this change across all OTel SDKs. Please review in the meantime.

This change is apart of an ongoing project for all of OpenTelemetry language SDKs to be moved towards support for the Lambda Lineage attribute in the X-Ray trace header via W3C Baggage. See open-telemetry/opentelemetry-java-contrib#1671 for the equivalent Java solution. This PR updates X-Ray propagator to pass lineage into baggage and inject it into outgoing X-Ray trace header.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

XRay propagator will still need to use baggage to store Lineage information but we omit adding any sort of additional baggage data to the xray trace header. Instead Baggage context will remain propagated using W3C Baggage.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests were written to verify that the extraction and injection logic were correct. Older unit tests were deprecated and deleted.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@liustve liustve requested a review from a team as a code owner January 30, 2025 18:46
@github-actions github-actions bot requested a review from NathanielRN January 30, 2025 18:46
@liustve liustve marked this pull request as draft January 30, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants