VertexAI handle streaming requests #3331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned alizenhom, codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
WIP using shared context manager Properly implement uninstrument Shared code with a contextmanager tmp
xrmx
reviewed
Mar 10, 2025
| get_genai_response_attributes(response) | ||
| ) | ||
|
|
||
| for event in response_to_events( |
There was a problem hiding this comment.
I'm not sure this is the case for vertexai too but in other instrumentations we pass the span explicitly to the code sending events. This is because at the time we evaluate the stream response the span has been already closed
There was a problem hiding this comment.
This is because at the time we evaluate the stream response the span has been already closed
Isn't the span supposed to remain un-finished until the last response is received?
Anyways, calls to this function happen under the yield stmt on L148 before the "with" block from L117 exits. So the span should be accessible in Context even if it were ended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3297
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.