Fix system metrics unit tests on mac #3638
Open
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The system metrics tests on mac are failing:
tox -e py312-test-instrumentation-system-metrics -- -ra
The issue is easy to understand
opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Line 144 in 109173f
But in the unit tests this metric is still tested.
Fixes # (issue)
Type of change
Skip the check of this metric on mac
Please delete options that are not relevant.
How Has This Been Tested?
Run Unit test on mac and see that everything passes
tox -e py312-test-instrumentation-system-metrics -- -ra
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.