Update celery instrumentation to follow semantic conventions #3712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-contrib into semconv-celery
tammy-baylis-swi
approved these changes
Sep 2, 2025
tammy-baylis-swi
moved this to Easy to review / merge / close
in @xrmx's Python PR digest
xrmx
reviewed
Sep 10, 2025
| @@ -20,7 +20,9 @@ | |||
| from celery import registry # pylint: disable=no-name-in-module | |||
| from celery.app.task import Task | |||
|
|
|||
| from opentelemetry.semconv.trace import SpanAttributes | |||
| from opentelemetry.semconv._incubating.attributes import ( | |||
| messaging_attributes as SpanAttributes, | |||
There was a problem hiding this comment.
That makes it harder when grepping for the old SpanAttributes module users, please convert the callers from SpanAttributes to messaging_attributes
xrmx
reviewed
Sep 10, 2025
| ) | ||
|
|
||
| meter_provider = kwargs.get("meter_provider") | ||
| meter = get_meter( | ||
| __name__, | ||
| __version__, | ||
| meter_provider, | ||
| schema_url="https://opentelemetry.io/schemas/1.11.0", | ||
| schema_url="https://opentelemetry.io/schemas/1.37.0", |
There was a problem hiding this comment.
Semconvs suggest to make the move to a newer semconv opt-in via OTEL_SEMCONV_STABILITY_OPT_IN, see
https://opentelemetry.io/docs/specs/semconv/messaging/
We have already some tooling in place for handling these in opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
xrmx
moved this from Easy to review / merge / close
to Reviewed PR that needs fixing
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump celery schema version from 1.11.0 to 1.37.0 and update the instrumentation to follow semantic conventions.
Fixes #1640
Breaking Changes:
messaging.destinationbymessaging.destination.namemessaging.conversation_idbymessaging.message.conversation_idmessaging.destination_kindType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.