-
Notifications
You must be signed in to change notification settings - Fork 800
Add DB-API sqlcomment mysql_client_version fallback #3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add DB-API sqlcomment mysql_client_version fallback #3729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some docker tests, I fixed a crash in the psycopg commenter code extracting the libpq version recently and the mocks were not matching reality.
@xrmx done, ptal. I tried to add one for the |
Description
Stops stacktraces when programmatic instrumentation with sqlcommenting is enabled in some cases.
Fixes #3730
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.