Remove sin
& sout
states from system.swap.*
if they can not be computed
#3741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
SystemMetricsInstrumentor
.system.network.connections
, then the metric will be removed and a warning is logged.system.swap.usage
orsystem.swap.utilization
, thesin
andsout
states will be removed from both metrics and a warning is logged.RuntimeWarning
emitted bypsutil
is (narrowly) suppressed wheneverpsutil.swap_memory
is called in gauge callbacks.Fixes #3740
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Added a dedicated test for this functionality:
Ran it against several Python versions as follows:
Note that it's set to only run on Linux.
Does This PR Require a Core Repo Change?
No.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.