flask: fixed http_server_request_duration metrics being recorded for excluded urls #3794
+35
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metrics was being recorded for excluded urls.
|
In the current scenario, when requests are made to the excluded 
After the change, server request duration metrics are recorded only for non-excluded URLs. In this case, 3 requests were made to the 
|
xrmx
reviewed
Oct 10, 2025
xrmx
changed the title
xrmx
reviewed
Oct 10, 2025
| duration_attrs_old = otel_wsgi._parse_duration_attrs( | ||
| attributes, _StabilityMode.DEFAULT | ||
| ) | ||
| if flask.request and ( |
There was a problem hiding this comment.
Maybe we can extract an helper function instead of duplicating the check in _start_response?
There was a problem hiding this comment.
@xrmx Added a helper function that is called here and in _start_response
xrmx
moved this from Ready for review
to Reviewed PRs that need fixes
in @xrmx's Python PR digest
emdneto
reviewed
Oct 14, 2025
| ) | ||
| self.assertTrue(number_data_point_seen and histogram_data_point_seen) | ||
| self.assertTrue(number_data_point_seen) | ||
| self.assertFalse(histogram_data_point_seen) |
emdneto
reviewed
Oct 14, 2025
| excluded_urls is None | ||
| or not excluded_urls.url_disabled(flask.request.url) | ||
| ): | ||
| if _should_exclude_request(excluded_urls): |
There was a problem hiding this comment.
I think you'll have to do something like:
+ should_trace = False
def _start_response(status, response_headers, *args, **kwargs):
- if flask.request and (
- excluded_urls is None
- or not excluded_urls.url_disabled(flask.request.url)
- ):
+ nonlocal should_trace
+ should_trace = _should_trace(excluded_urls)
+ if should_trace:
and
+ def _should_trace(excluded_urls) -> bool:
+ return bool(
+ flask.request.url
+ and (excluded_urls is None or not excluded_urls.url_disabled(flask.request.url))
+ )
emdneto
reviewed
Oct 14, 2025
|
|
||
| ### Fixed | ||
|
|
||
| - `opentelemetry-instrumentation-flask`: Fixed http_server_request_duration metrics being recorded for excluded urls. |
There was a problem hiding this comment.
Suggested change
| - `opentelemetry-instrumentation-flask`: Fixed http_server_request_duration metrics being recorded for excluded urls. | |
| - `opentelemetry-instrumentation-flask`: Do not record `http.server.duration` metrics for excluded URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue #2352 where
http_server_request_durationmetrics was being recorded for excluded urls.Description
Fixes #2352
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.