botocore: Add AWS_LAMBDA_RESOURCE_MAPPING_ID Semantic Convention Support for AWS Lambda SDK #3800
+157
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S Lambda SDK This PR adds support for the AWS_LAMBDA_RESOURCE_MAPPING_ID semantic convention attribute in the AWS Lambda SDK instrumentation library. https://github.com/open-telemetry/semantic-conventions/blob/main/docs/registry/attributes/aws.md#amazon-lambda-attributes It also introduces the following two experimental attributes. Work is currently underway to add these keys to the AWS section of the Semantic Conventions registry: aws.lambda.function.arn aws.lambda.function.name Name is extracted from request object. ARN is extracted from response object. Resource Mapping ID is extracted from both request and response objects. This behavior is covered by unit tests. Tests Added new unit tests (passing). Verified with: tox -e py312-test-instrumentation-botocore tox -e spellcheck tox -e lint-instrumentation-botocore tox -e ruff Backward Compatibility This change is backward compatible. It only adds instrumentation for additional AWS resources and does not modify existing behavior in the auto-instrumentation library.
lukeina2z
changed the title
yiyuan-he
reviewed
Sep 30, 2025
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_lambda.py
Show resolved
Hide resolved
yiyuan-he
reviewed
Sep 30, 2025
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_lambda.py
Show resolved
Hide resolved
yiyuan-he
reviewed
Sep 30, 2025
...metry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/lmbd.py
Show resolved
Hide resolved
lukeina2z
force-pushed
the
pr-lambda
branch
from
bce20a8 to
83747fb
Compare
|
@lukeina2z @yiyuan-he thanks for your PRs and reviews, what do you think on being listed as component owner for the botocore instrumentation since you seem to have an interest in it? |
|
@xrmx Thanks Riccardo, I'd be happy come onboard as a component owner! |
yiyuan-he
reviewed
Oct 1, 2025
...metry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/lmbd.py
Show resolved
Hide resolved
I am happy to contribute. Let's move forward. |
Thanks, please approve #3806 |
xrmx
reviewed
Oct 10, 2025
Comment on lines
+27
to
+28
| - `opentelemetry-exporter-credential-provider-gcp`: create this package which provides support for supplying your machine's Application Default Credentials (https://cloud.google.com/docs/authentication/application-default-credentials) to the OTLP Exporters created automatically by OpenTelemetry Python's auto instrumentation. These credentials authorize OTLP traces to be sent to `telemetry.googleapis.com`. | ||
| [#3766](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3766). |
There was a problem hiding this comment.
Suggested change
| - `opentelemetry-exporter-credential-provider-gcp`: create this package which provides support for supplying your machine's Application Default Credentials (https://cloud.google.com/docs/authentication/application-default-credentials) to the OTLP Exporters created automatically by OpenTelemetry Python's auto instrumentation. These credentials authorize OTLP traces to be sent to `telemetry.googleapis.com`. | |
| [#3766](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3766). |
xrmx
reviewed
Oct 10, 2025
| from opentelemetry.trace.span import Span | ||
|
|
||
| # Work is underway to add these two keys to the SemConv AWS registry, in line with other AWS resources. | ||
| # https://github.com/open-telemetry/semantic-conventions/blob/main/docs/registry/attributes/aws.md#amazon-lambda-attributes |
There was a problem hiding this comment.
We usually don't add attributes before they're added to semconv, do you want to wait for these to get there or move the usage of these attributes to another PR?
| return function_name_or_arn if function_name is None else function_name | ||
| if function_name_or_arn is None: | ||
| return None | ||
| matches = _OpInvoke.ARN_LAMBDA_PATTERN.match(function_name_or_arn) |
There was a problem hiding this comment.
I don't understand why you are moving to a staticmethod while still referencing class attributes but not an issue for me 😅
xrmx
moved this from Ready for review
to Reviewed PRs that need fixes
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the AWS_LAMBDA_RESOURCE_MAPPING_ID semantic convention attribute in the AWS Lambda SDK instrumentation library.
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/registry/attributes/aws.md#amazon-lambda-attributes
It also introduces the following two experimental attributes. Work is currently underway to add these keys to the AWS section of the Semantic Conventions registry:
aws.lambda.function.arn
aws.lambda.function.name
Name is extracted from request object.
ARN is extracted from response object.
Resource Mapping ID is extracted from both request and response objects. This behavior is covered by unit tests.
Backward Compatibility
This change is backward compatible. It only adds instrumentation for additional AWS resources and does not modify existing behavior in the auto-instrumentation library.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added new unit tests (passing).
Verified with:
tox -e py312-test-instrumentation-botocore
tox -e spellcheck
tox -e lint-instrumentation-botocore
tox -e ruff
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.