DB semantic convention stability migration for DB-API and 7 inheriting db client instrumentors#4109
Open
tammy-baylis-swi wants to merge 15 commits intoopen-telemetry:mainfrom
Open
Conversation
| try: | ||
| result[key] = int(value) | ||
| except ValueError: | ||
| except (ValueError, TypeError): |
Contributor
Author
There was a problem hiding this comment.
Not sure why A failure started happening in this PR instead of in #4108 with tox -e py3*-test-opentelemetry-instrumentation-aiopg because of aiopg instrumentor dependency on this. Example run with error:
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'Mock'
tammy-baylis-swi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add DB-API instrumentor support for when
OTEL_SEMCONV_STABILITY_OPT_INincludes "database" or "database/dup".This changes the
SQLComment in span attributefeature if opted in. Inclusion of sqlcomment on query span would be ondb.statementand/ordb.query.textattribute if default, "database", or "database/dup".These instrumentors inherit DB-API's
wrap_connectand/orinstrument_connection, and therefore also gain support for semconv migration automatically:Fixes #2929 #2678 #2928 #2931 #2932 #2933 #2934
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.