feat: add ability to configure flush behavior for AWS lambda instrumentation#4158
Open
herin049 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
feat: add ability to configure flush behavior for AWS lambda instrumentation#4158herin049 wants to merge 2 commits intoopen-telemetry:mainfrom
herin049 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
| ) | ||
|
|
||
|
|
||
| def _get_env_bool(env_var: str, default: bool) -> bool: |
Contributor
There was a problem hiding this comment.
I'm surprised there isn't something like this already in contrib nor the SDK repo -- I couldn't find one either.
xrmx
reviewed
Feb 5, 2026
| By default, the instrumentation force flushes both traces and metrics after each Lambda invocation. | ||
| This behavior can be controlled with the following environment variables: | ||
|
|
||
| * ``OTEL_INSTRUMENTATION_AWS_LAMBDA_FORCE_FLUSH``: Enables or disables force flushing for all signal types. Defaults to ``true``. |
Contributor
There was a problem hiding this comment.
If these are Python specific they should be OTEL_PYTHON_ prefixed, e.g. OTEL_PYTHON_AWS_LAMBDA_FORCE_FLUSH
| if value is None: | ||
| return default | ||
| value = value.strip().lower() | ||
| if value in ("y", "yes", "t", "true", "on", "1"): |
Contributor
There was a problem hiding this comment.
We should just care about true per:
https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#boolean
Contributor
Author
There was a problem hiding this comment.
The issue I see with that is that we cannot allow explicitly setting this option to false. Should I make this a number (i.e. 0/1) instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to configure flush behavior in AWS Lambda instrumentation.
Fixes #4157
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.