Add host.id resource detector - #4843
Open
jaydeluca wants to merge 14 commits into
Open
Conversation
herin049
requested changes
Jul 22, 2026
| return SimpleNamespace(stdout=stdout, stderr="", returncode=return_code) | ||
|
|
||
|
|
||
| class HostIdResourceDetectorTest(TestBase): |
Contributor
There was a problem hiding this comment.
Can we update these tests so that they test as much of the functionality end-to-end as possible? Almost everything is being patched here, which doesn't make these tests that useful. Our CI runs on both Linux and Windows so you should be able to at least test these systems end-to-end.
…, switch statement
jaydeluca
commented
Jul 22, 2026
herin049
reviewed
Jul 24, 2026
| self.assertIn(HOST_ID, resource.attributes) | ||
| host_id = resource.attributes[HOST_ID] | ||
| self.assertIsInstance(host_id, str) | ||
| self.assertTrue(host_id) |
Contributor
There was a problem hiding this comment.
Can we make a stronger assertion here: that this is a 32 character lowercase hexadecimal string, or better yet read the contents of /etc/machine-id or /var/lib/dbus/machine-id
emdneto
reviewed
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
host.idresource detector following the semconv spec, and using the java agent implementation as a reference.Fixes #4830
Type of change
How Has This Been Tested?
I wrote a small test app, and added
Ran the app (on macOS) and observed the attribute
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.