Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[user_events logs] Remove Arc reference from eventheader provider #143

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Dec 16, 2024

Changes

The Arc is not required for eventheader-provider, so removing it. This has significant perf improvements as updated in the results.

Before (refer: #142)
is_enabled:true:
1 thread: 30,866,752 iterations/sec
16 threads: 16,915,860 iterations/sec

After:
is_enabled:false
1 thread: 41,555,620 iterations/sec
16 threads: 20,119,895 iterations/sec

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner December 16, 2024 14:13
@lalitb lalitb changed the title [user_events logs] Remove Arc reference from eventheader provider with perf improvement [user_events logs] Remove Arc reference from eventheader provider Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.1%. Comparing base (67b30de) to head (2e9fa5c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pentelemetry-user-events-logs/src/logs/exporter.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #143   +/-   ##
=====================================
  Coverage   54.1%   54.1%           
=====================================
  Files         42      42           
  Lines       6276    6276           
=====================================
  Hits        3401    3401           
  Misses      2875    2875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

Changes

The Arc is not required for eventheader-provider, so removing it. This has nit improvement in perf too.

Before (refer: #142) is_enabled:true: 1 thread: 30,866,752 iterations/sec 16 threads: 16,915,860 iterations/sec

After: is_enabled:false 1 thread: 41,555,620 iterations/sec 16 threads: 20,119,895 iterations/sec

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Not sure if the perf number makes sense as it appears significant. could you double check and update the description?

@lalitb
Copy link
Member Author

lalitb commented Dec 17, 2024

Not sure if the perf number makes sense as it appears significant. could you double check and update the description?

Yes perf improvement is significant for single threaded scenario, and good for others too. Have updated the title, and description and also updated the results in code.

@lalitb lalitb requested a review from cijothomas January 2, 2025 08:50
@cijothomas cijothomas merged commit 2ccb00e into open-telemetry:main Jan 9, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants