Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 2, 2025

  • Add support for Resource attributes in ETW logs exporter
  • Add with_resource_attributes() method to ProcessorBuilder
  • Implement resource attribute filtering and export
  • Add comprehensive tests for resource attribute functionality
  • Format code using cargo fmt
  • Resolve all merge conflicts with main branch (CHANGELOG fully resolved)
  • Add debug logging for ignored resource attributes
  • All tests passing (34 tests)

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cijothomas / name: Cijo Thomas (01dc1bc, 05525e3)
  • ✅ login: Copilot / name: copilot-swe-agent[bot] (05525e3)

Copilot AI changed the title [WIP] Add support Resource attributes in eta-logs exporter feat: Add support for Resource attributes in ETW logs exporter Aug 2, 2025
Copilot AI requested a review from cijothomas August 2, 2025 00:21
Copilot finished work on behalf of cijothomas August 2, 2025 00:21
@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

❌ Patch coverage is 96.61017% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.2%. Comparing base (b49f00e) to head (05525e3).

Files with missing lines Patch % Lines
opentelemetry-etw-logs/src/exporter/mod.rs 92.9% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #410     +/-   ##
=======================================
+ Coverage   53.8%   54.2%   +0.3%     
=======================================
  Files         71      71             
  Lines      11687   11797    +110     
=======================================
+ Hits        6299    6405    +106     
- Misses      5388    5392      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cijothomas
Copy link
Member

/easycla

@cijothomas
Copy link
Member

@copilot There are lint failures. Analyze and fix them. You can run cargo fmt --all to fix most of them.

Copy link
Contributor Author

Copilot AI commented Aug 6, 2025

@copilot There are lint failures. Analyze and fix them. You can run cargo fmt --all to fix most of them.

Fixed all formatting issues by running cargo fmt --all. The changes included import ordering, removing trailing whitespace, and properly formatting long lines and method chains. All 29 tests continue to pass. Commit: 0a01dad

Copilot finished work on behalf of cijothomas August 6, 2025 16:16
@cijothomas
Copy link
Member

@copilot Resolve the conflicts

Copy link
Contributor Author

Copilot AI commented Nov 5, 2025

@copilot Resolve the conflicts

Resolved merge conflict in opentelemetry-etw-logs/CHANGELOG.md. The vNext section with the new resource attributes feature is now properly positioned above the v0.10.0 section. All tests continue to pass (34 tests). Commit: 2d0899e

Copilot finished work on behalf of cijothomas November 5, 2025 18:02
@cijothomas
Copy link
Member

@copilot The changelog still has conflicts. resolve all of them.

Copy link
Contributor Author

Copilot AI commented Nov 5, 2025

@copilot The changelog still has conflicts. resolve all of them.

Resolved all CHANGELOG merge conflicts with the latest main branch. The vNext section now properly contains the resource attributes feature, positioned above the v0.10.0 section. All tests continue to pass (34 tests). Commit: 6311045

Copilot finished work on behalf of cijothomas November 5, 2025 18:53
Copilot AI requested a review from cijothomas November 6, 2025 16:13
Copilot finished work on behalf of cijothomas November 6, 2025 16:14
@cijothomas cijothomas marked this pull request as ready for review November 6, 2025 16:23
@cijothomas cijothomas requested a review from a team as a code owner November 6, 2025 16:23
@cijothomas
Copy link
Member

@psandana Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants