Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document usage of multiple collector config files #5960

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Document usage of multiple collector config files #5960

wants to merge 5 commits into from

Conversation

meswapnilk
Copy link
Contributor

Closes #5296

@meswapnilk meswapnilk requested a review from a team as a code owner January 17, 2025 04:52
@opentelemetrybot opentelemetrybot requested review from a team and TylerHelmuth and removed request for a team January 17, 2025 04:52
@opentelemetrybot opentelemetrybot requested a review from a team January 17, 2025 04:58
tiffany76
tiffany76 requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @meswapnilk! I've made a few copy edit suggestions. Also, please see my comment about moving your addition a little higher on the page.

content/en/docs/collector/configuration.md Outdated Show resolved Hide resolved
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@meswapnilk
Move the new doc section
a1a7abe 
Signed-off-by: Swapnil Kulkarni <[email protected]>
tiffany76
tiffany76 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@open-telemetry/collector-approvers, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
sig:collector
Projects
SIG Comms: PRs & Issues
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of multiple collector config files is not clearly documented
2 participants
@meswapnilk @tiffany76