This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Enable owt dynamic library built out and fix adm init error issue.#309
Open
liukai1025 wants to merge 5 commits intoopen-webrtc-toolkit:masterfrom
liukai1025:master
Open
Enable owt dynamic library built out and fix adm init error issue.#309liukai1025 wants to merge 5 commits intoopen-webrtc-toolkit:masterfrom liukai1025:master
liukai1025 wants to merge 5 commits intoopen-webrtc-toolkit:masterfrom
liukai1025:master
Conversation
liukai1025
requested review from
HuaChunbo,
jianjunz and
taste1981
as code owners
Release unnecessary P2PPeerConnectionChannel object to fix memory leak issue.
Signed-off-by: Liu, Kai1 <kai1.liu@intel.com>
This reverts commit a0292e8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to use dynamic library of libowt, so submit one patch.
The second patch is to fix adm init failure issue on server platform which has no audio device.