Skip to content

To merge the initial changes to the develop branch to get review#25

Closed
PrathibaJee wants to merge 17 commits intoopenBackhaul:developfrom
PrathibaJee:develop
Closed

To merge the initial changes to the develop branch to get review#25
PrathibaJee wants to merge 17 commits intoopenBackhaul:developfrom
PrathibaJee:develop

Conversation

@PrathibaJee
Copy link
Copy Markdown
Collaborator

No description provided.

@PrathibaJee PrathibaJee requested a review from defney as a code owner February 7, 2025 09:42
@PrathibaJee PrathibaJee requested review from anacabbar and kmohr-soprasteria and removed request for anacabbar February 7, 2025 09:42
Copy link
Copy Markdown
Collaborator

@kmohr-soprasteria kmohr-soprasteria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagrams:

for other apps we have a README where all the diagrams are shown

DeleteMediatorInstance.plantuml

  • diagram looks a bit different from the diagrams we usually do (although I think it looks quite nice!)
  • what is the MM:APPDataFile listed here for? I don't see any operation on that in the diagram

DeleteMediatorVmTemplate.plantuml:

  • the notations are different than in DeleteMediatorInstance (e.g. there we have pink notes boxes for decisions), would be good if everything would look homogeneous
  • also: same as above in regards to callback names, etc.

MountNameAndDeviceIPDoesnotExist:

  • in box "create mediator instance" there's this arrow with a cross to Ericsson MIM; in case the x shall stand for that the MIM can't be reached, it should not have an backwards arrow that starts at the MIM, as the MIM doesn't know that it should have received the request

MountNameWithCorrectIPExistForDiffDeviceKindName.plantuml:
empty besides the title

MountNameWithCorrectIPExistForSameDeviceKindName.png:
maybe include the responseCodes != 200 with less detail (e.g. have just a single arrow for 5xx errors and a note box that describes when there's 5aa, when there's 5bb, 5cc etc.)


ServiceList:

  • http-server & tcp block info needs to be set correctly, also set ips (also for the InstanceManagers?) to 127.0.0.1 (modify documentation in Github accordingly)
  • old release has a wrong port (3007)
  • uuids of individual services with im and is - is this on purpose?

@kmohr-soprasteria kmohr-soprasteria self-requested a review February 7, 2025 15:30
@kmohr-soprasteria
Copy link
Copy Markdown
Collaborator

kmohr-soprasteria commented Feb 7, 2025

ProfileInstances has a String profile, but profiles doesn't

forwardingList:
ServiceRequestCausesLoggingRequest: doesn't have all individual services

Copy link
Copy Markdown
Collaborator

@kmohr-soprasteria kmohr-soprasteria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval for merging

@PrathibaJee
Copy link
Copy Markdown
Collaborator Author

Thank you for the review comments Katharina.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants