To merge the initial changes to the develop branch to get review#25
To merge the initial changes to the develop branch to get review#25PrathibaJee wants to merge 17 commits intoopenBackhaul:developfrom
Conversation
There was a problem hiding this comment.
Diagrams:
for other apps we have a README where all the diagrams are shown
DeleteMediatorInstance.plantuml
- diagram looks a bit different from the diagrams we usually do (although I think it looks quite nice!)
- normally services are listed as own grey boxes at the top, instead of the service being the label of the arrow (e.g. /v1/list-mediator-instances) (on the labels normally the input parameters (or response parameters) are shown.
- usually we also have diagrams with callback names in the title, and if there are substeps, these can also be provided in the note boxes as underlined text (see example from NEP: https://github.com/openBackhaul/NetExplorerProxy/blob/development/spec/diagrams/050_ProvideNepDataStatistics.png)
- what is the MM:APPDataFile listed here for? I don't see any operation on that in the diagram
DeleteMediatorVmTemplate.plantuml:
- the notations are different than in DeleteMediatorInstance (e.g. there we have pink notes boxes for decisions), would be good if everything would look homogeneous
- also: same as above in regards to callback names, etc.
MountNameAndDeviceIPDoesnotExist:
- in box "create mediator instance" there's this arrow with a cross to Ericsson MIM; in case the x shall stand for that the MIM can't be reached, it should not have an backwards arrow that starts at the MIM, as the MIM doesn't know that it should have received the request
MountNameWithCorrectIPExistForDiffDeviceKindName.plantuml:
empty besides the title
MountNameWithCorrectIPExistForSameDeviceKindName.png:
maybe include the responseCodes != 200 with less detail (e.g. have just a single arrow for 5xx errors and a note box that describes when there's 5aa, when there's 5bb, 5cc etc.)
ServiceList:
- http-server & tcp block info needs to be set correctly, also set ips (also for the InstanceManagers?) to 127.0.0.1 (modify documentation in Github accordingly)
- old release has a wrong port (3007)
- uuids of individual services with im and is - is this on purpose?
|
ProfileInstances has a String profile, but profiles doesn't forwardingList: |
kmohr-soprasteria
left a comment
There was a problem hiding this comment.
approval for merging
|
Thank you for the review comments Katharina. |
No description provided.