feat(rules): add missing rules from OpenEMR upstream #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three rules that exist in OpenEMR's .phpstan/ directory: - ForbiddenCurlFunctionsRule: Blocks raw curl_* functions, requires PSR-18 HTTP client instead of Guzzle-specific recommendation - ForbiddenMethodsRule: Blocks deprecated methods like GenID() - ForbiddenStaticMethodsRule: Blocks QueryUtils transaction methods, requires inTransaction() wrapper Includes tests for all new rules. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ForbiddenCurlFunctionsRuleto block rawcurl_*functions (requires PSR-18 HTTP client)ForbiddenMethodsRuleto block deprecated methods likeGenID()ForbiddenStaticMethodsRuleto blockQueryUtils::startTransaction()etc. (requiresinTransaction()wrapper)Test plan
composer checkpasses🤖 Generated with Claude Code