Add rake tasks to cleanup and backfill data in bs_request_actions table #17319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubhanazeem
force-pushed
the
backfill-source_ids_in_request_action
branch
from
328f8fc to
b85c3f6
Compare
|
Aren't those data migrations? |
rubhanazeem
force-pushed
the
backfill-source_ids_in_request_action
branch
from
b85c3f6 to
ff2aab6
Compare
We decided to keep this in task |
danidoni
reviewed
Jan 31, 2025
| desc('Insert source_project_id and source_package_id in bs_request_actions') | ||
| task(backfill_source: :environment) do | ||
| bs_request_actions = BsRequestAction.where(source_project_id: nil, source_package_id: nil).where('source_project IS NOT NULL OR source_package IS NOT NULL') | ||
| bs_request_actions.find_each do |action| |
There was a problem hiding this comment.
I think you better use chunked iterators, or it will try to load the whole collection of elements in memory...
danidoni
reviewed
Jan 31, 2025
| desc('Remove target_project_id and target_package_id from bs_request_actions if the projects and packages no longer exist') | ||
| task(remove_target: :environment) do | ||
| bs_request_actions = BsRequestAction.where('target_project_id IS NOT NULL OR target_package_id IS NOT NULL') | ||
| bs_request_actions.find_each do |action| |
|
I split this PR into two, converting the rake tasks to data migrations. See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new tasks, both of which modify the
BsRequestActionstable:bin/rails backfill_sourceto add source project/package_idBefore executing the task make some calculations:
This query returns the number of records that need to be updated. Run it both before and after executing the task. Ideally, the count after execution should be significantly lower than before. However, some BsRequestAction records would remain unchanged if their sources have been removed. To verify that the task has been executed successfully, inspect a random subset of records.
bin/rails remove_targetto remove target project/package association if they no longer exist.The count should increase after executing this task, indicating that target project/package associations that no longer exist have been removed.